Skip to content

CI: fix rust-toolchain.toml and doctests #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025

Conversation

pchickey
Copy link
Contributor

@pchickey pchickey commented Aug 8, 2025

CI is broken:

  • rust-toolchain.toml was overriding the toolchain to 1.82 locally, but not on CI. The latest rust 1.89, running on CI, would fail due to doctests picking up more than before with --target wasm32-wasip2.
  • the failing doctests are now fixed

@pchickey pchickey requested a review from yoshuawuyts August 8, 2025 18:05
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@yoshuawuyts yoshuawuyts merged commit 383902a into main Aug 11, 2025
4 checks passed
@pchickey pchickey deleted the pch/fix_toolchain_doctests branch August 11, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants